Recorded music sales peaked in 1999- then came Napster and other ways to listen to the exact music you want for free. Recorded music sales still haven’t fully recovered, but with the rapid growth of paid streaming since 2014, they have been increasing again:

Meanwhile, live music sales have exploded since the ’90s:

The latest report from Pollstar on the top live tours is positively glowing:
2023 was a colossus, the likes of which the live industry has never before seen. If 2022 was a historic record-setting year, which it was, then this year completely blew it out of the water— by double digits. Total grosses for the 2023 Worldwide Top 100 Tours were up 46% to $9.17 billion
When you combine live and recorded sales, total spending on music has now passed the 1999 peak; this is the biggest the market for music has ever been. Of course, this doesn’t mean its an easy time to be a musician; touring is hard work and, as always, record labels and others are taking a big share of the money before it gets to artists. And opinions differ about whether today’s environment is good for creating good new music.

There are dozens of songs about how the road is hard, and the more time you spend on the road, the less they sound like cliches than like a simple and sometimes stark description of your life. Sooner or later everybody spots the exit that has their name on it –John Darnielle
The BLS data is noisy but suggests that the number of musicians in the US has been fairly flat and is projected to stay that way. A lot will depend on whether live music continues to grow, how much of that is captured by a few superstars, and whether the current streaming paradigm continues, or goes in a more or less artist-friendly direction. But now that consumers are willing to pay for music again, artists at least have a fighting chance.